Remove webflux #85
Merged
Remove webflux #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2023 09:31
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
added 6 commits
October 11, 2023 12:27
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
SlimaneAmar
reviewed
Oct 11, 2023
| }) | ||
| .block(); | ||
| startTime.set(System.nanoTime()); | ||
| try { |
There was a problem hiding this comment.
Use the same template as other computations for try/catch into remove the code smell
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| public class SecurityAnalysisException extends RuntimeException { | |||
| public enum Type { | |||
| RESULT_NOT_FOUND | |||
| RESULT_NOT_FOUND, | |||
| RUN_AS_ERROR | |||
There was a problem hiding this comment.
not anymore, removing it
| @RunWith(SpringRunner.class) | ||
| @ContextConfiguration(classes = {SecurityAnalysisApplication.class, TestChannelBinderConfiguration.class}) |
There was a problem hiding this comment.
Perhaps use ContextConfigurationWithTestChannel like study server ?
FranckLecuyer
approved these changes
Oct 12, 2023
added 2 commits
October 12, 2023 14:12
Signed-off-by: LE SAULNIER Kevin <[email protected]>
klesaulnier
commented
Oct 16, 2023
| @RunWith(SpringRunner.class) | ||
| @ContextConfiguration(classes = {SecurityAnalysisApplication.class, TestChannelBinderConfiguration.class}) |
There was a problem hiding this comment.
use ContextConfigurationWithTestChannel
| @RunWith(SpringRunner.class) | ||
| @ContextConfiguration(classes = {SecurityAnalysisApplication.class, TestChannelBinderConfiguration.class}) |
There was a problem hiding this comment.
use ContextConfigurationWithTestChannel
jonenst
approved these changes
Oct 16, 2023
added 3 commits
October 16, 2023 13:53
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
SlimaneAmar
approved these changes
Oct 16, 2023
added 2 commits
October 17, 2023 10:40
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
SlimaneAmar
approved these changes
Oct 17, 2023
klesaulnier
added a commit
that referenced
this pull request
Oct 20, 2023
… Remove webflux (#85) Signed-off-by: LE SAULNIER Kevin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.